Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Runtime dependency in xunit.execution.DotNetCore #559

Closed
herecydev opened this issue Aug 27, 2015 · 7 comments
Closed

System.Runtime dependency in xunit.execution.DotNetCore #559

herecydev opened this issue Aug 27, 2015 · 7 comments

Comments

@herecydev
Copy link

The NetPlatform TFM for xunit.execution.DotNetCore has a dependency on System.Runtime (4.0.20). When I target dotnet and have xunit (beta4) as the only dependency it throws errors similar to the following:

image

I'm guessing that the incorrect version of System.Runtime is being pulled in, 4.0.0 instead of 4.0.20. Anything I'm doing wrong here?

Thanks

@clairernovotny
Copy link
Member

What kind of project do you have, what are your dependencies, what is your target platform?

@herecydev
Copy link
Author

I have an xproj targeting dotnet, with the only dependency on xunit.

image

@bradwilson
Copy link
Member

  • If you are using DNX beta6 or earlier: revert back to xUnit.net 2.1 beta 3.
  • If you are using DNX beta7 or later: Use the latest build from our CI MyGet feed: https://www.myget.org/F/xunit/ (xunit will be an rc1 build, and xunit.runner.dnx will be a beta5 build)

@bradwilson
Copy link
Member

Also, do not target dotnet with a .xproj today. It doesn't work the way you expect it to.

@herecydev
Copy link
Author

Okay thanks, do you have any additional information about dotnet with xproj? Oren had some confusion to begin with, but his recent blogs indicate that this should be the correct target.

@bradwilson
Copy link
Member

For starters, dotnet is for class libraries only. If you're building an application, it needs to target one or more specific frameworks.

In addition, the dotnet target basically means "I intend to be compatible with anything which can link against System.Runtime". There is really no mechanism today to limit that to specific targets. In addition, the things you want to link against -- ASP.NET, specifically -- don't necessarily have dotnet targets themselves (looking at Microsoft.AspNet.Http.1.0.0-beta7-15511, I see dual binaries for dnx451 and dnxcore50).

If I were making a class library for use with ASP.NET today, I would follow the two-target strategy.

@herecydev
Copy link
Author

Okay thanks, it is a class library I'm creating. I will hold off until more has been established. Cheers for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants