Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go module support #28

Merged
merged 1 commit into from Jan 15, 2019
Merged

Add go module support #28

merged 1 commit into from Jan 15, 2019

Conversation

BluesJhao
Copy link
Contributor

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #28 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #28     +/-   ##
=========================================
+ Coverage   86.65%   86.76%   +0.1%     
=========================================
  Files          27       27             
  Lines        1836     1836             
=========================================
+ Hits         1591     1593      +2     
+ Misses        189      184      -5     
- Partials       56       59      +3
Impacted Files Coverage Δ
utils.go 76.92% <0%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b06eae...f65c013. Read the comment docs.

@xuri xuri merged commit 15c8a55 into xuri:master Jan 15, 2019
@xuri
Copy link
Owner

xuri commented Jan 15, 2019

A nice addition, thanks @BluesJhao.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants