Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPicture can get only one picture in a cell #1548

Closed
yicixin opened this issue May 26, 2023 · 1 comment · Fixed by #1549
Closed

getPicture can get only one picture in a cell #1548

yicixin opened this issue May 26, 2023 · 1 comment · Fixed by #1549
Labels
bug Something isn't working
Projects
v2.8.0

Comments

@yicixin
Copy link
Contributor

yicixin commented May 26, 2023

Description
I tried the feature of getting multiple images in a cell introduced in 2.7.1, but after testing I could only get one of them.
I think the problem is with this line.

https://github.com/qax-os/excelize/blob/76cd0992b038ceaad87a471f81cbde503423cc85/picture.go#LL675C6-L675C12
@xuri
Copy link
Member

xuri commented May 26, 2023

Thanks for your issue. Would you like create a pull request to help us to fix this issue by remove return statements?

@xuri xuri added the bug Something isn't working label May 26, 2023
@yicixin yicixin mentioned this issue May 26, 2023
Merged
10 tasks
@xuri xuri added this to Bugfix in v2.8.0 May 27, 2023
@xuri xuri linked a pull request May 27, 2023 that will close this issue
remove return statements to fix the issue which you could only get one picture on a cell #1549
Merged
10 tasks
xuri pushed a commit that referenced this issue May 27, 2023
@yicixin
This closes #1548, support to get multiple images in one cell (#1549)
e3fb2d7
xuri pushed a commit to JDavidVR/excelize that referenced this issue Jul 11, 2023
@yicixin @xuri
This closes qax-os#1548, support to get multiple images in one cell (q…
a035c62 
…ax-os#1549)
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
@yicixin
This closes qax-os#1548, support to get multiple images in one cell (q…
72a4cd3 
…ax-os#1549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
v2.8.0
Bugfix
Milestone
No milestone
2 participants
@xuri @yicixin