Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetConditionalStyle #1690

Closed
franissirkovic opened this issue Oct 12, 2023 · 11 comments
Closed

GetConditionalStyle #1690

franissirkovic opened this issue Oct 12, 2023 · 11 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects

Comments

@franissirkovic
Copy link

Description
I am very satisfied with excelize lib. As far as I can see all functions come in get/set pairs, for example NewStyle()/GetStyle(). But I have found one exception: there is only NewConditionalStyle() function. There are no GetConditionalStyle() function. So, it makes conditional styles something like write only memory (register). And, of course, I need GetConditionalStyle() function. I can't find style for conditionally highlighted cells.

I would appreciate if you can add it.
In the meantime I have found ugly workaround, I am accessing file.Styles.Dxfs.Dxfs directly.

Best wishes, Franis Sirkovic.

@xuri xuri added enhancement New feature or request in progress Working in progress labels Oct 12, 2023
@xuri xuri closed this as completed in b52db71 Oct 17, 2023
@xuri
Copy link
Member

xuri commented Oct 17, 2023

Thanks for your issue. I have just added support for getting the conditional format style definition, please upgrade to the master branch code, and this feature will be released in the next version.

@xuri xuri added this to Features in v2.8.1 Oct 17, 2023
@xuri xuri removed the in progress Working in progress label Oct 17, 2023
@franissirkovic
Copy link
Author

franissirkovic commented Oct 17, 2023 via email

@xuri
Copy link
Member

xuri commented Oct 18, 2023

Thanks for your feedback. I have tested this with unit tests, and it works well. Are you opening an existing workbook that contains a conditional format style or creating a conditional format style on a new workbook with this library? Could you provide a file attachment without confidential info and a standalone demo to reproduce this?

@franissirkovic
Copy link
Author

franissirkovic commented Oct 18, 2023 via email

@xuri
Copy link
Member

xuri commented Oct 18, 2023

I can't find your attachments in your reply, you can upload attachment to this issue, and show us a standalone reproducible source code demo.

@franissirkovic
Copy link
Author

franissirkovic commented Oct 18, 2023 via email

@xuri
Copy link
Member

xuri commented Oct 18, 2023

I still can't find your attachments in your reply, could you upload it by webpage instead of reply by email? In addition, please show us a standalone reproducible source code demo instead of binary files.

@franissirkovic
Copy link
Author

Here is xlsx file and source files of utility.
demo.tar.gz

@franissirkovic
Copy link
Author

franissirkovic commented Oct 18, 2023 via email

@xuri xuri added the in progress Working in progress label Oct 18, 2023
xuri added a commit that referenced this issue Oct 19, 2023
- Improve compatibility with the viewer which doesn't support default theme part namespace
- ref #1690, support read background color style, and conditional format with default pattern type
- Update the unit tests
@xuri
Copy link
Member

xuri commented Oct 19, 2023

I have made some changes to resolve this issue, please try to upgrade the master branch code. This change will be released in the next version.

@xuri xuri removed the in progress Working in progress label Oct 19, 2023
@franissirkovic
Copy link
Author

It works perfectly for my case. Thanks for help.

Best wishes, Franis Sirkovic.

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
- Support get the conditional format style definition
- Update the unit test
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
- Improve compatibility with the viewer which doesn't support default theme part namespace
- ref qax-os#1690, support read background color style, and conditional format with default pattern type
- Update the unit tests
@xuri xuri added the duplicate This issue or pull request already exists label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
No open projects
v2.8.1
Features
Development

No branches or pull requests

2 participants