Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory consumption by trimming the rows and cells #1712

Closed
krstak opened this issue Nov 6, 2023 · 0 comments · Fixed by #1713
Closed

Memory consumption by trimming the rows and cells #1712

krstak opened this issue Nov 6, 2023 · 0 comments · Fixed by #1713
Labels
enhancement New feature or request
Projects

Comments

@krstak
Copy link
Contributor

krstak commented Nov 6, 2023

Description

By having a lot of rows and columns, memory consumption increases a lot. The reason is that we always allocate a new underlying array instead of re-using the existing one.

Steps to reproduce the issue:

  1. By trying to convert a huge amount of rows (30000+) into the xlsx

Describe the results you received:

trimCell issue:
heap1

trimRow issue: (append)
heap-append

Describe the results you expected:

We can reusing the existing underlying array instead of always allocating a new one.

Output of go version:

1.21

Excelize version or commit ID:

v2.7.1

Environment details (OS, Microsoft Excel™ version, physical, etc.):

@xuri xuri added the enhancement New feature or request label Nov 6, 2023
@krstak krstak mentioned this issue Nov 6, 2023
10 tasks
@xuri xuri added this to Performance in v2.8.1 Nov 6, 2023
@xuri xuri linked a pull request Nov 6, 2023 that will close this issue
10 tasks
@xuri xuri closed this as completed in #1713 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2.8.1
Performance
Development

Successfully merging a pull request may close this issue.

2 participants