DeleteComment is no deletion marker

[baichachaa]

After I deleted the comment, there was still the comment.
As you can see the code:

f.SetCellValue("Sheet1", "A2", 100)
f.AddComment("Sheet1", excelize.Comment{Cell: "A2", Text: "aaa"})
f.DeleteComment("Sheet1", "A2")

go version： go1.21.3 windows/amd64
excelize version： 2.8.0

[xuri]

Thanks for your issue. Could you show us a complete, standalone example program or reproducible demo? I have tested with the following code and it works well.

package main

import (
    "fmt"

    "github.com/xuri/excelize/v2"
)

func main() {
    f := excelize.NewFile()
    defer func() {
        if err := f.Close(); err != nil {
            fmt.Println(err)
        }
    }()
    if err := f.SetCellValue("Sheet1", "A2", 100); err != nil {
        fmt.Println(err)
        return
    }
    if err := f.AddComment("Sheet1", excelize.Comment{Cell: "A2", Text: "aaa"}); err != nil {
        fmt.Println(err)
        return
    }
    if err := f.DeleteComment("Sheet1", "A2"); err != nil {
        fmt.Println(err)
        return
    }
    if err := f.SaveAs("Book1.xlsx"); err != nil {
        fmt.Println(err)
    }
}

[baichachaa]

I used your code and it's still the same as I described.
Maybe it's an issue with WPS Office.
WPS Office Version: 12.1.0.16120

[xuri]

Thanks for your feedback. This issue has been fixed, please try to upgrade the master branch code, and this patch will be released in the next version.