Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fix performance impact introduced in #1692 #1849

Merged
merged 1 commit into from Mar 15, 2024

Conversation

ha5ky
Copy link
Contributor

@ha5ky ha5ky commented Mar 15, 2024

No description provided.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2024
@xuri xuri added this to Performance in v2.9.0 Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (585ebff) to head (297c64f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1849   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          32       32           
  Lines       23959    23963    +4     
=======================================
+ Hits        23770    23774    +4     
  Misses        101      101           
  Partials       88       88           
Flag Coverage Δ
unittests 99.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 4eb088c into qax-os:master Mar 15, 2024
35 checks passed
@ha5ky
Copy link
Contributor Author

ha5ky commented Mar 15, 2024

LGTM, thanks for your contribution.

my pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
v2.9.0
Performance
Development

Successfully merging this pull request may close these issues.

None yet

2 participants