Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after #842 "avoid empty rows in the tail of the worksheet", lost some formula cell data #855

Closed
raochq opened this issue Jun 2, 2021 · 1 comment
Labels
confirmed This issue can be reproduced
Projects

Comments

@raochq
Copy link
Contributor

raochq commented Jun 2, 2021

after fix this bug. I have another problem when I copy a sheet to another file.
I use GetRows function to get all data, and then I iterates data and use GetCellFormula to get the formula.
after fix this bug. I lost the last cell whose value is empty and it is a formula cell.

I think it can be changed like this.

https://github.com/360EntSecGroup-Skylar/excelize/blob/master/rows.go#L168

if val != "" || colCell.F != nil {
	rowIterator.columns = append(appendSpace(blank, rowIterator.columns), val)
}
@xuri xuri added the confirmed This issue can be reproduced label Jun 2, 2021
@xuri xuri closed this as completed in d932e62 Jun 4, 2021
@xuri
Copy link
Member

xuri commented Jun 4, 2021

Thanks for your feedback, I have fixed it, please try to use the master branch code, and this patch will be released in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This issue can be reproduced
Projects
No open projects
v2.4.1
Bugfix
Development

No branches or pull requests

2 participants