Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set can be slow #27

Closed
arj03 opened this issue Aug 12, 2020 · 3 comments · Fixed by #28
Closed

Set can be slow #27

arj03 opened this issue Aug 12, 2020 · 3 comments · Fixed by #28

Comments

@arj03
Copy link
Contributor

arj03 commented Aug 12, 2020

I'm storing rather large datasets in idb using this library. And I have noticed that because set broadcasts its set value even if not really used this tends to slow this quite a bit.

There doesn't seem to be a good way to disable this so I'm looking for input on how to change this behaviour.

Thanks :)

@arj03 arj03 changed the title Set causes Set can be slow Aug 12, 2020
@xuset
Copy link
Owner

xuset commented Aug 12, 2020

Hey @arj03, yeah that is unfortunate. I'm thinking there's a few easy code changes that could be made to solve that. Maybe if opts.channel is explicitly set to null then that functionality should be disabled or possible just adding a new disable broadcasting like option to opts. Either way though, if you open a PR we can get those changes in

@arj03
Copy link
Contributor Author

arj03 commented Aug 12, 2020

Thanks for your quick response @xuset. I have created a PR to resolve this issue.

@xuset xuset closed this as completed in #28 Aug 13, 2020
@xuset
Copy link
Owner

xuset commented Aug 13, 2020

Added in v4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants