Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: table export: implement support for Firefox export as .xlsx .ods .csv .pdf #711

Closed
foss- opened this issue Apr 1, 2021 · 9 comments

Comments

@foss-
Copy link

foss- commented Apr 1, 2021

Describe the bug
Currently export in Chromium browsers supports .xlsx .ods .bin .csv .pdf
while Firefox only supports export as .bin

Expected behavior
Would be great if Firefox could support export to those common formats as well.

Browser (please complete the following information):

  • OS: macOS 11.2.3
  • Browser: Firefox 89.0a1 (2021-04-01) (64-Bit)
@ansuz
Copy link
Contributor

ansuz commented Apr 1, 2021

Hi,
Are you testing this on CryptPad.fr or your own instance?

@foss-
Copy link
Author

foss- commented Apr 1, 2021

Sorry my bad. This is instance specific and I will follow up with the responsible person. Excuse the noise.

@foss- foss- closed this as completed Apr 1, 2021
@meaz
Copy link

meaz commented Apr 1, 2021

I see the exact same thing on cryptpad.fr...

@ansuz
Copy link
Contributor

ansuz commented Apr 1, 2021

@meaz: this feature depends on some fairly new APIs being enabled in client browsers. It may break under extreme conditions: such as when using an old version of Firefox (ESR) or Edge/IE, if you've made modifications to your about:config, or if you're running extensions which actively interfere with standard behaviour.

@meaz
Copy link

meaz commented Apr 1, 2021

thanks ansuz

@meaz
Copy link

meaz commented Apr 2, 2021

@ansuz I've tried with firefox 87, with no plugin and no change in about:config.
It is working fine on cryptpad.fr but not on cryptpad.disroot.org. CHromium works on both.
Could it be a server issue? And if yes, what should we be looking for?

@ansuz
Copy link
Contributor

ansuz commented Apr 2, 2021

@meaz the most likely explanation is that you're not setting the headers that enable SharedArrayBuffer.

@meaz
Copy link

meaz commented Apr 2, 2021

@ansuz it is set. I forgot to tell you that I have this error with firefox only, not chromium...

@ansuz
Copy link
Contributor

ansuz commented Apr 2, 2021

@ansuz it is set. I forgot to tell you that I have this error with firefox only, not chromium...

There are around 700 third-party instances, so ss a rule we can't realistically spend much time helping to configure them. That said, here's a quick check that suggests the headers aren't being set as you believe.

ansuz:~$ for d in https://cryptpad.fr https://cryptpad.disroot.org;do echo $d;curl -vvv $d/common/onlyoffice/v4/web-apps/apps/spreadsheeteditor/main/index.html --stderr - | grep "cross-origin";echo;done;
https://cryptpad.fr
< cross-origin-resource-policy: cross-origin
< cross-origin-embedder-policy: require-corp

https://cryptpad.disroot.org

We've been developing a "checkup" page (/checkup/) that automatically runs some diagnostics on instances to detect these common errors. I'll try to integrate this test into that page before our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants