Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cleaning group pages names when migrating confluence rights #65

Closed
mouhb opened this issue Feb 2, 2024 · 2 comments
Closed

Allow cleaning group pages names when migrating confluence rights #65

mouhb opened this issue Feb 2, 2024 · 2 comments
Assignees
Milestone

Comments

@mouhb
Copy link

mouhb commented Feb 2, 2024

Some context :

Currently users that are migrating large confluence instances with lots of users and groups are also doing a batch import of their users/group on XWiki before the running the migration. The LDAP User Import Application is for example used to import all groups and users available on an LDAP directory and to fill the groups with the corresponding users.
When a group is imported using the "LDAP User Import" Application (which is using the XWiki LDAP Authenticator API) the name of the group page created on XWiki is always cleaned, meaning that spaces, dots ('.'), and slashes (/) are removed from the original group name found in LDAP side. See : https://github.com/xwikisas/application-ldapuserimport/blob/main/application-ldapuserimport-api/src/main/java/com/xwiki/ldapuserimport/internal/job/DefaultLDAPGroupImportJob.java#L122. The method org.xwiki.contrib.ldap.XWikiLDAPUtils.java#cleanXWikiUserPageName(String pageName) is used to clean the group names. Also, note that all group names generated by the LDAP Authenticator API by default ends by the word "Group" which is an XWiki best practice for groups pages. So, for example we have the group name "Company All" in LDAP side the group "CompanyAllGroup" will be generated in XWiki side.

The issue with the Confluence Migrator is that when the rights are imported the group names set on the rights objects are kept as they are found on the confluence package except if a group mapping is provided. So, it would be nice if we have an option in the Confluence Migrator that forces cleaning and adding the word 'Group' on group names set during the rights migration.

@raphj
Copy link
Contributor

raphj commented Feb 20, 2024

@raphj raphj self-assigned this Feb 20, 2024
@raphj raphj added this to the 1.11.4 milestone Feb 20, 2024
@raphj raphj closed this as completed Feb 21, 2024
@raphj
Copy link
Contributor

raphj commented Feb 23, 2024

See also #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants