Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Groups' drop-down filter box should display only groups added on entries (instead of all existing groups on the wiki) #26

Closed
ilieandriuta opened this issue Jan 16, 2019 · 2 comments

Comments

@ilieandriuta
Copy link

@ilieandriuta ilieandriuta commented Jan 16, 2019

Preconditions: The XWiki instance has some groups already created (e.g. G1, G2, G3).

STEPS TO REPRODUCE

  1. Go to Flash Messages App
  2. Create a flash entry by filling the 'Groups' with a group (e.g. G1)
  3. Create another flash entry by filling other group (e.g. XWikiAdminGroup)
  4. Go to Flash Messages homepage
  5. Click on drop-down box from the 'Groups' column on the live table

EXPECTED RESULTS

The drop-down box displays for filtering only the groups that were added in the existing entries (e.g. G1 and XWikiAdminGroup).

ACTUAL RESULTS

In drop-down box there are displayed all the existing groups from the wiki (screenshots attached).

flash_groups1

flash_groups2

Environment: Windows 10 Pro 64 bit, Chrome 71, using a local instance XWiki 10.8.3 on PostgreSQL 10

@ilieandriuta ilieandriuta added this to the 1.4 milestone Jan 16, 2019
@oanalavinia oanalavinia removed this from the 1.4 milestone Feb 20, 2019
@oanalavinia oanalavinia added this to the 2.0 milestone Feb 20, 2019
@arcilli arcilli self-assigned this Jul 4, 2019
@arcilli
Copy link

@arcilli arcilli commented Jul 4, 2019

Partially solved in #37. After discussions with @acotiuga, we decided to offer all the list with groups (in case that an user want to filter the messages and no result is found for that group, he should see that it's no result).

@acotiuga
Copy link
Collaborator

@acotiuga acotiuga commented Jul 4, 2019

Displaying all the groups seems to be the default behavior in the product. I'm not in favor of changing it here and even if we would do so, we have to update all the other extensions in order to keep a consistent feature. I'm closing this issue as the proposed fix represents also a big improvement.

@acotiuga acotiuga closed this Jul 4, 2019
@acotiuga acotiuga removed this from the 2.0 milestone Jul 11, 2019
@acotiuga acotiuga added this to the 1.4.4 milestone Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants