Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The excerpt-include macro is named Excerpt #192

Closed
michitux opened this issue Jan 26, 2024 · 2 comments · Fixed by #194
Closed

The excerpt-include macro is named Excerpt #192

michitux opened this issue Jan 26, 2024 · 2 comments · Fixed by #194
Assignees
@oanalavinia
Labels
Type: Bug
Milestone
1.14.5

Comments

@michitux
Copy link

The excerpt-include macro is wrongly named "Excerpt" and has also the same description as the actual excerpt macro. This makes it impossible to distinguish them in the macro insertion dialog.
@acotiuga
Copy link
Contributor

This will be fixed when #194 will be merged.

@oanalavinia oanalavinia linked a pull request Feb 9, 2024 that will close this issue
Excerpt-include macro does not display images from excerpt #190 #194
Merged
@oanalavinia oanalavinia added this to the 1.14.4 milestone Feb 9, 2024
@oanalavinia oanalavinia self-assigned this Feb 9, 2024
@raphj raphj removed this from the 1.14.4 milestone Feb 14, 2024
@raphj
Copy link
Contributor

raphj commented Feb 14, 2024

This needed to be reverted, see #190 (comment)

@raphj raphj reopened this Feb 14, 2024
@acotiuga acotiuga mentioned this issue Feb 14, 2024
Closed
@raphj raphj added this to the 1.14.5 milestone Feb 14, 2024
@raphj raphj closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Type: Bug
Projects
No open projects
ProAppsRoadmapJan-Feb2024
Status: Done
Milestone
1.14.5
Development

Successfully merging a pull request may close this issue.

Excerpt-include macro does not display images from excerpt #190 acotiuga/xwiki-pro-macros
4 participants
@michitux @raphj @acotiuga @oanalavinia