Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApsInitialize: CreateDirectory result is not checked properly #2

Closed
gl-bars opened this issue Apr 8, 2015 · 1 comment
Closed

ApsInitialize: CreateDirectory result is not checked properly #2

gl-bars opened this issue Apr 8, 2015 · 1 comment

Comments

@gl-bars
Copy link

gl-bars commented Apr 8, 2015

Status = CreateDirectory(ApsLogPath, NULL);
if (Status != APS_STATUS_OK && Status != ERROR_ALREADY_EXISTS) {
  return Status;
}

CreateDirectory returns just BOOL, while ERROR_ALREADY_EXISTS is returned by GetLastError. When log or sym directory did not exist (but was just created), the program thinks there was an error and terminates silently.

@xwlan
Copy link
Owner

xwlan commented Sep 22, 2015

Thanks. The problem is fixed in: f416b81

@xwlan xwlan closed this as completed Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants