Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips to Tab Bar #258

Open
jwold opened this issue May 25, 2020 · 5 comments
Open

Add tooltips to Tab Bar #258

jwold opened this issue May 25, 2020 · 5 comments

Comments

@jwold
Copy link

jwold commented May 25, 2020

Feature description


There are times when the tab bar headings can be set without labels. In this scenario an icon is added without a label. We should ensure that the icon can be given a tooltip.

Acceptance criteria

  1. Handle this however we handle the Icon Button block.
  • Add a new label input field into the block sidebar.
  • Allow the new field to be visible regardless of whether there is a heading on the tab or not.

Note: Similar to #224 where we could add a field in the block sidebar settings to add a tooltip.

Implementation brief

QA testing instructions

Demo

Changelog entry

@jwold jwold added the Phase 2 label May 25, 2020
@jwold jwold added this to Prioritization in Definition via automation May 25, 2020
@jwold jwold moved this from Prioritization to Revisit Later in Definition May 25, 2020
@jwold
Copy link
Author

jwold commented Jul 3, 2020

We recognize that this is not necessarily ideal because you could have a tooltip that is the same as the label. But for now this seems like an ok solution to ship with.

cc @jbingham and @yasmineevjen

@jwold jwold added Phase 3 and removed Phase 2 labels Jul 9, 2020
@jwold
Copy link
Author

jwold commented Sep 25, 2020

Closing for now, goes against guidance.

@jwold jwold closed this as completed Sep 25, 2020
@jauyong jauyong self-assigned this Dec 10, 2020
@jauyong jauyong removed this from Revisit Later in Definition Dec 10, 2020
@jauyong
Copy link

jauyong commented Dec 10, 2020

Handle this however we handle the Icon Button block.

@jauyong jauyong reopened this Dec 10, 2020
@jauyong
Copy link

jauyong commented Dec 16, 2020

@jwold I've added a Tab block with no label but I don't see an icon being added. Can you confirm the issue?
https://dev-mdc-web.pantheonsite.io/wp-admin/post.php?post=1909&action=edit

Editor:
image

Front end:
image

@jauyong jauyong added this to Backlog in Execution Dec 16, 2020
@jwold
Copy link
Author

jwold commented Jan 14, 2021

@jauyong I think the issue is ready for engineering, but recorded a quick video to make sure.

Video: https://v.usetapes.com/fvY0cE215T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Execution
  
Backlog
Development

No branches or pull requests

2 participants