Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gallery (grid view) on Mobile #491

Closed
jauyong opened this issue Jan 5, 2021 · 5 comments · Fixed by #555
Closed

Improve Gallery (grid view) on Mobile #491

jauyong opened this issue Jan 5, 2021 · 5 comments · Fixed by #555
Assignees
Labels
Projects
Milestone

Comments

@jauyong
Copy link

jauyong commented Jan 5, 2021

Feature description

As a user, I would like an improved experience for the gallery block on a mobile device.

This came from Yasmine's request regarding to the grid view for the Gallery block on mobile. See slack message here.
image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  1. Conduct quick competitive analysis of similar blocks in the WordPress space to identify the best method for showcasing gallery blocks and giving content creators the best controls to modify the experience. Reviewed by Joshua.
  2. The labels do not need to be cut off but break on the word (ie multiple lines) See Add Line Breaks to Gallery Block #497
  3. Allow admins to set number of columns per device (desktop, tablet, mobile). The following are the defaults:
    1. desktop = 5 or 6,
    2. tablet (768px) = 3 or 4,
    3. mobile = 1
  4. On mobile, I should be able to set 1 column

Implementation brief

QA testing instructions

Demo

Changelog entry

@jauyong jauyong added this to Backlog in Execution Jan 5, 2021
@jwold jwold self-assigned this Jan 14, 2021
@jauyong jauyong assigned jwold and unassigned jwold Jan 14, 2021
@jwold jwold removed their assignment Jan 14, 2021
@jwold
Copy link

jwold commented Jan 14, 2021

@jauyong I can't remember if there was anything needed from me on this one. I think we're ready for engineering.

@jauyong
Copy link
Author

jauyong commented Jan 15, 2021

@jwold we were thinking of having default columns for each device type. what are your thoughts?
(desktop = 5 or 6, tablet (768px) = 3 or 4, mobile = 1)

@jauyong
Copy link
Author

jauyong commented Jan 15, 2021

@jauyong to break this out into a separate ticket:
AC2
The labels do not need to be cut off but break on the word (ie multiple lines)

@jwold
Copy link

jwold commented Jan 15, 2021

@jwold we were thinking of having default columns for each device type. what are your thoughts?
(desktop = 5 or 6, tablet (768px) = 3 or 4, mobile = 1)

That works.

@jwold jwold removed their assignment Jan 15, 2021
@jauyong jauyong moved this from Backlog to To Do in Execution Feb 5, 2021
@ravichdev ravichdev moved this from To Do to In Progress in Execution Feb 8, 2021
@ravichdev ravichdev self-assigned this Feb 8, 2021
@ravichdev ravichdev moved this from In Progress to Code Review in Execution Mar 5, 2021
Execution automation moved this from Code Review to Done Mar 9, 2021
@ravichdev ravichdev reopened this Mar 12, 2021
Execution automation moved this from Done to Backlog Mar 12, 2021
@ravichdev ravichdev moved this from Backlog to QA in Execution Mar 12, 2021
@jauyong jauyong added this to the 0.2.0 milestone Mar 19, 2021
@ravichdev ravichdev removed their assignment Mar 22, 2021
@ravichdev
Copy link
Contributor

@csossi This is ready for QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Execution
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants