New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings Page #534
Comments
@jwold do I recall correctly that you wanted to take a look at this first? |
@jwold Aaron just confirmed that you wanted to look at this first to provide a design, so passing it on to you. There were comments to mirror the existing "getting started" look and feel, but I'm sure you'll work out what's best ;) |
Reassigning to @dawidmlynarz to take a look |
Hey @jauyong , here is my first draft and a quick prototype of the Settings page. I tried to keep the same styles from the 'Getting Started' page to keep consistency. The first section of the page is Things I've additionally included into the concept:
Take a look at the quick prototype recording and let me know your thoughts. Settings.page.-.Concept.-.V1.movLooking forward to your feedback! |
Please have a look at the revisited version of the Settings page. The following changes were made: Settings.+.Google.API.Key.movLooking forward to more feedback on this. |
When the API key is entered, and the user returns to the page, the key should be hidden like a password is. Or consider removing the text field altogether. (look at Github secrets) Jason to update AC and reference the ticket to reset settings. |
@jauyong Here is the proposal of how can we handle the 'hidden state'. We can display it again once someone wants to edit it. The question to consider is: Should this access be password protected? |
@dawidmlynarz good question. Password protection wasn't mentioned when we were discussing this. I feel like that could cause more headaches for us and the user through complexities like password management. We can ask the team though. I also remember it being mentioned that users shouldn't be able to edit the keys, but only remove them. I don't see any notes here and that your approved video demo shows an edit button. @rodydavis can you confirm:
|
@dawidmlynarz to make the following update:
no need for password protection. |
@dawidmlynarz Looks good, for the API key field, after a user enters the key and saves it, they wouldn't be able to see it. It will be |
@dawidmlynarz Would you happen to have either the figma link or a sketch file with these updates? Wondering if I can get the color values or there more specifics that I can't get in the videos |
@emeaguiar I have sent you Figma link via Slack. Let me know if you have access. |
Feature description
As a plugin user, I want to be able to manage my settings such as updating fonts and icons
This is a blocker to #460 and #461
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Add option to delete cache, reset demo content, hard reset theme... @jauyong to create a ticket for this. need to identify what can be reset. This ticket will help users troubleshoot and get back to a stable default state.Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: