Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded editor overlays expand button for collapsed Customizer pane #44

Closed
westonruter opened this issue Mar 9, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@westonruter
Copy link
Contributor

commented Mar 9, 2016

If the editor is expanded and the collapse link for the Customizer pane is clicked, the pane will slide away but the button to re-expand the panel will be behind the editor and so the user will be stuck.

@westonruter westonruter added the bug label Mar 9, 2016

@westonruter westonruter changed the title Fix expanded editor from overlaying expand button for collapsed Customizer pane Expanded editor overlays expand button for collapsed Customizer pane Mar 9, 2016

@ahmadawais

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2016

We can also shift the open/close button to the top or something to help with the manual override.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2016

This is closely related to https://core.trac.wordpress.org/ticket/36678

There should be a state for whether the Customize pane is expanded and the editor should collapse whenever this state changes to collapsed.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2016

Or, as @stuartshields notes, they may want the editor visible with the pane collapsed for more real estate. So the expand button may just need a higher z-index.

@valendesigns

This comment has been minimized.

Copy link
Member

commented Apr 29, 2016

Or it could be moved up 300px to come into view and then a higher z-index in fullscreen mode.

@stuartshields

This comment has been minimized.

Copy link

commented Apr 29, 2016

@valendesigns I've done a quick concept of just adding the z-index in, I agree with you, we'd need to move it up by 300px otherwise it'll get lost if the user has a screenshot/video in the post. See below of it in a normal post.

screen shot 2016-04-30 at 7 41 55 am

@valendesigns

This comment has been minimized.

Copy link
Member

commented Apr 29, 2016

@stuartshields Yes, that would be very confusing in that placement. However, in fullscreen mode it would probably be OK to keep it there.

@stuartshields

This comment has been minimized.

Copy link

commented Apr 30, 2016

@valendesigns

This comment has been minimized.

Copy link
Member

commented Apr 30, 2016

Awesome, thanks. I'll review it later tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.