Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Expanded editor overlays expand button for collapsed Customizer pane #44

Closed
westonruter opened this issue Mar 9, 2016 · 8 comments
Closed
Assignees
Labels
Milestone

Comments

@westonruter
Copy link
Contributor

If the editor is expanded and the collapse link for the Customizer pane is clicked, the pane will slide away but the button to re-expand the panel will be behind the editor and so the user will be stuck.

@westonruter westonruter added the bug label Mar 9, 2016
@westonruter westonruter changed the title Fix expanded editor from overlaying expand button for collapsed Customizer pane Expanded editor overlays expand button for collapsed Customizer pane Mar 9, 2016
@ahmadawais
Copy link
Contributor

We can also shift the open/close button to the top or something to help with the manual override.

@westonruter
Copy link
Contributor Author

This is closely related to https://core.trac.wordpress.org/ticket/36678

There should be a state for whether the Customize pane is expanded and the editor should collapse whenever this state changes to collapsed.

@westonruter
Copy link
Contributor Author

Or, as @stuartshields notes, they may want the editor visible with the pane collapsed for more real estate. So the expand button may just need a higher z-index.

@valendesigns
Copy link
Contributor

Or it could be moved up 300px to come into view and then a higher z-index in fullscreen mode.

@stuartshields
Copy link

@valendesigns I've done a quick concept of just adding the z-index in, I agree with you, we'd need to move it up by 300px otherwise it'll get lost if the user has a screenshot/video in the post. See below of it in a normal post.

screen shot 2016-04-30 at 7 41 55 am

@valendesigns
Copy link
Contributor

@stuartshields Yes, that would be very confusing in that placement. However, in fullscreen mode it would probably be OK to keep it there.

@stuartshields
Copy link

@valendesigns This was pretty simple to do with CSS. Here is the branch - https://github.com/xwp/wp-customize-posts/tree/bugfix%2F44-expanded-editor-overlay

@valendesigns
Copy link
Contributor

Awesome, thanks. I'll review it later tonight.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants