Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Format tag slugs in readme.md #262

Closed
kasparsd opened this issue Dec 6, 2017 · 0 comments
Closed

Format tag slugs in readme.md #262

kasparsd opened this issue Dec 6, 2017 · 0 comments

Comments

@kasparsd
Copy link
Contributor

kasparsd commented Dec 6, 2017

The readme convertor is converting all plugin tags into links but it doesn't format the tag slut to replace spaces with dashes. This results in broken links:

https://github.com/georgestephanis/two-factor/blob/330e36a09c1f744e176275bf42fd7b07b5f2d09a/readme.md

We should replace all spaces with slashes here:

$formatted_metadata['Tags'] = join(
', ',
array_map(
function ( $tag ) {
return sprintf( '[%1$s](https://wordpress.org/plugins/tags/%1$s)', $tag );
},
$this->metadata['Tags']
)
);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant