Add Request day().add(object)

[hijazikaram]

Describe the bug
Hi,

I kind of like this project, I'd like to use it to add an object instead of just using add(value: number, unit: string). I was using moment before but im moving into using dayjs because its way smaller.

Expected behavior
const maxTimestamp = moment(this.endDate.value.valueOf()) .utc() .startOf('day'); maxTimestamp.add({ hours: minTime.slice(0, 2), minutes: minTime.slice(3, 5) });
Trying to switch that into:
const maxTimestamp = day(this.endDate.value.valueOf()) .utc() .startOf('day'); maxTimestamp.add({ hours: minTime.slice(0, 2), minutes: minTime.slice(3, 5) });
Information

• Day.js Version [e.g. v1.0.0]
• OS: [e.g. iOS]
• Browser [e.g. chrome 62]

[ghost]

Trying to switch that into:

Exact the same with above line?

[hijazikaram]

@xxyuk the first one im using moment, trying to use dayjs instead

[iamkun]

Yes, we could support this as a plugin to add a time object.

[hijazikaram]

Having the same issue with this
startDateTime = startDateTime.set({ hour: startTime.get('hours'), minutes: startTime.get('minutes'), seconds: startTime.get('seconds') }); endDateTime = endDateTime.set({ hour: endTime.get('hours'), minutes: endTime.get('minutes'), seconds: startTime.get('seconds') });

[hijazikaram]

dayjs doesnt let you set an object

[iamkun]

What's the best name for these two plugins?

AdvancedGet SetObject AdvancedAddSubtract?

[hijazikaram]

AdvancedGet AdvancedSet

[hijazikaram]

etc...

[iamkun]

But add && subtract is actually the same function, so there's no need adding two separate AdvancedAdd & AdvancedSubtract, but if there's only one AdvancedAdd, it may get some user confusing that why no AdvancedSubtract.

[hijazikaram]

You can do AdvancedAddSubtract

[hijazikaram]

Can you hit me up when you add them please so i can close this issue
Thanks!

[iamkun]

Sure. You could do dayjs.add().add().add() at this moment.

[hijazikaram]

wow i didnt know that you can do that lol

[hijazikaram]

can i do the same with .set

[hijazikaram]

I did something like this for the .add
const minutes = +(minTime.slice(0, 2) * 60) + +minTime.slice(3, 5); newMinTimestamp = minTimestamp.add(minutes, 'minute'); minTimestamp = newMinTimestamp;

[hijazikaram]

@iamkun is it possible i can do this endTime = day(df.endTime, 'HH:mm:ss'); instead of endTime = moment(df.endTime, 'HH:mm:ss'). Doing it right now will return NAN

[iamkun]

yes, customParseFormat plugin, please.

[hijazikaram]

i have it added but its not doing anything

[hijazikaram]

do i have to do something like day.customParseFormat()

[iamkun]

online demo or sample code, please.

[hijazikaram]

import * as moment from 'moment'; import * as day from 'dayjs'; import * as utc from 'dayjs/plugin/utc'; import * as customParseFormat from 'dayjs/plugin/customParseFormat'; day.extend(customParseFormat); day.extend(utc); public updatetime() { const df = this.dateFilter; let startDateTime = moment(df.startDate); let endDateTime = day(df.endDate); let startTime = day() .utc() .startOf('day'); let endTime = day() .utc() .endOf('day'); console.log(endTime) if (df.startTime) { startTime = day(df.startTime, 'HH:mm:ss'); } if (df.endTime) { console.log(df.endTime) console.log(day(df.endTime).format('HH:mm:ss')) endTime = day(df.endTime, 'HH:mm:ss'); } startDateTime = startDateTime.set({ hour: startTime.get('hour'), minutes: startTime.get('minute'), seconds: startTime.get('second') }); // endDateTime = endDateTime.set({ // hour: endTime.get('hours'), // minutes: endTime.get('minutes'), // seconds: startTime.get('seconds') // }); df.startDate = startDateTime.toDate(); df.endDate = endDateTime.toDate(); }

[hijazikaram]

@iamkun hope this helps

[hijazikaram]

drf.endtime should always equal something like 12:04

[hijazikaram]

I think i got it, im sending in a a time that doesnt have seconds, its breaking it. In moment, if the time doesnt have seconds, it automatically add the seconds to the time :00

[iamkun]

We just released the ObjectSupport plugin to support this. https://day.js.org/docs/en/plugin/object-support