Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Questions about loss_reweighting.py #10

Open
believewhat opened this issue Oct 2, 2022 · 3 comments
Open

Some Questions about loss_reweighting.py #10

believewhat opened this issue Oct 2, 2022 · 3 comments

Comments

@believewhat
Copy link

Hello, author, in the cov function of loss_reweighting.py. I think there is a little different with the definition in the paper:
Your code: cov = torch.matmul((w * x).t(), x)
Your paper:
T}USG}2ICE}E02SL 84(1O1
Why the code is not cov = torch.matmul((w * x).t(), w * x)
Thank you very much.

@allenwang2333
Copy link

I'm also very confused at that part. The cov in code is calculating the covariance not of the projection to RFF space, but the original space. I think that u and v here means projection to the RFF space.

@zmcwsd
Copy link

zmcwsd commented Sep 9, 2023

i think you are right,i agree

@TianmingXie
Copy link

I think the authors calculate the covariance matrix through Cov(X, Y)=E(XY)-E(X)E(Y), but not following the formula in the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants