combine game high&standard #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
combine game high and standard, also fix the problem when the team sucks and the highest Plus/Minus is 0
combine game high&standard
homerchen19
reviewed
Nov 17, 2017
src/command/game/boxScore.js
Outdated
| `${field_goals_made}-${field_goals_attempted}`, | ||
| `${three_pointers_made}-${three_pointers_attempted}`, | ||
| `${free_throws_made}-${free_throws_attempted}`, | ||
| checkOverStandard(plus_minus, 15), |
There was a problem hiding this comment.
This is the only difference place between two cases, right?
I don't think this is necessary, cuz it's still the highest in the team even though it's 0.
There was a problem hiding this comment.
I got it, I will remove that part of code and pull the request again.
Btw thanks for the reply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combine game high and standard, also fix the problem when the team
sucks and the highest Plus/Minus is 0
PS. I'm just a college student, if my code has any problem feel free to tell me :)