Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPI code integration #171

Closed
xxks-kkk opened this issue Oct 30, 2019 · 1 comment
Closed

EPI code integration #171

xxks-kkk opened this issue Oct 30, 2019 · 1 comment
Labels
C++ good C++ usage and practice; C++ usage note infrastructure Code infrastucture should be reusued in the future implementation (e.g., better test case org)

Comments

@xxks-kkk
Copy link
Owner

EPI has better C++ code implementation and definition than Leetcode's. Using leetcode has negative impact on C++ practice. Try to integrate EPI code along with test infrastructure in the repo and point to the EPI implementation whenever we can find the same leetcode problem in EPI.

See PR #168 Todo section on one example.
@xxks-kkk xxks-kkk added infrastructure Code infrastucture should be reusued in the future implementation (e.g., better test case org) C++ good C++ usage and practice; C++ usage note labels Oct 30, 2019
@xxks-kkk
Copy link
Owner Author

xxks-kkk commented Jan 21, 2020 •
edited

Fixed via #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ good C++ usage and practice; C++ usage note infrastructure Code infrastucture should be reusued in the future implementation (e.g., better test case org)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xxks-kkk