Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path setting across all projects #127

Closed
huyz opened this issue Oct 4, 2022 · 8 comments
Closed

Path setting across all projects #127

huyz opened this issue Oct 4, 2022 · 8 comments

Comments

@huyz
Copy link

huyz commented Oct 4, 2022

Every time I open a new project, the plugin asks me to set the path for golangci-lint.

Can the setting be remembered and shared for all projects?

@xxpxxxxp
Copy link
Owner

xxpxxxxp commented Oct 8, 2022

Hi @huyz , sorry for that, I know it is frustrating, some people want different configurations per project (eg. #109 #115), so this 1-time pop-up is useful in such cases.

@xxpxxxxp xxpxxxxp closed this as completed Oct 8, 2022
@huyz
Copy link
Author

huyz commented Oct 8, 2022

Is it possible to have the path for .golangci.yml be per-project while the path for golangci-lint be across all projects? That would satisfy everyone I think

@huyz
Copy link
Author

huyz commented Oct 8, 2022

Or maybe copy the per-project path golangci-lint to an across-projects default setting. Then whenever a new project is encountered, the across-projects default setting can be copied to the per-project path for this new project

@xxpxxxxp
Copy link
Owner

Good idea, the plugin can skip setup if

  • there's golangci-lint exe in PATH
  • there's .golangci.yml config for current project

Otherwise, it would be better for user config the plugin for 1 time, as default linters are far from good for most cases.

@dekimsey
Copy link

there's golangci-lint exe in PATH

Was this implemented? I see the discussion about the changed occurred after the issue was closed. In my case the binary is in my PATH but it prompting on every load.

GoLand 2022.2.5
Go Linter 1.6.3

Thank you!

@xxpxxxxp
Copy link
Owner

@dekimsey sryI totally forgot this, doing now

@xxpxxxxp xxpxxxxp reopened this Jan 12, 2023
@xxpxxxxp
Copy link
Owner

done, open a new project that has .golangci.yml under its path and a golangci-lint executable under $PATH will not show pop-up.

@huyz
Copy link
Author

huyz commented Mar 19, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants