Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish getEmployeeList() and fire() in UI/fire.js #68

Closed
hanayashiki opened this issue Nov 6, 2017 · 2 comments
Closed

Finish getEmployeeList() and fire() in UI/fire.js #68

hanayashiki opened this issue Nov 6, 2017 · 2 comments
Assignees

Comments

@hanayashiki
Copy link
Collaborator

在master上将最新commit pull到本地,注意game.fire如果冲突应该全部用新的game.fire中的改动
注释有误,下个commit修正;
fire需要完成:开除index指定的员工
getEmployeeList返回指定格式的当前已雇佣员工

@si1entic
Copy link
Collaborator

si1entic commented Nov 7, 2017

已提交,并调试出一个UI的bug:
fire.js里多个函数用到this.candidates,但properties里并没有该属性,所以运行时显示undefined。
已添加该属性。
实测雇佣+解雇功能已完成。

一个建议:
每个子窗口能否增加返回/取消按钮。比如玩家查看可雇佣列表后选择放弃,目前只再点左侧按钮,不太友好。

@si1entic si1entic closed this as completed Nov 7, 2017
@hanayashiki
Copy link
Collaborator Author

我计划是点击外部即可返回,还没实现。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants