Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Details lost if Endpoint Identifier not set #33

Closed
azurecurve opened this issue Jan 28, 2020 · 2 comments
Closed

Plugin Details lost if Endpoint Identifier not set #33

azurecurve opened this issue Jan 28, 2020 · 2 comments
Assignees
Labels
Status: Completed This item has been implemented or otherwise addressed. Type: Defect This item is an error or other behavior that negatively impacts code execution.
Milestone

Comments

@azurecurve
Copy link

Description

When creating a new plugin endpoint, if you omit the endpoint Identifier the Plugin Details are lost when saving.

Steps to Reproduce

  1. Create a new plugin endpoint.
  2. Enter a name.
  3. Leave the Endpoint Identifier blank.
  4. Enter Plugin Details.
  5. Hit Update.
  6. See blank Plugin Details.

Expected Behavior

Plugin Details should be retained and an error presented.

Environment

Under which type of environment did you experience this problem?

Desktop

  • Operating System: Windows 10
  • Browser & Version: Vivaldi 2.10.1745.27 (Stable channel) (64-bit)
@johnalarcon
Copy link
Collaborator

The identifier is the glue that holds a given record together; without it, there's no way to associate the data. So, I'm leaning toward disabling the update/publish operation (via JS) until the identifier field is populated. I'll think on it. Thanks for the report.

@johnalarcon johnalarcon added Status: Pending This item is planned, but, has no projected timeline. Type: Defect This item is an error or other behavior that negatively impacts code execution. labels Jan 28, 2020
@johnalarcon johnalarcon added this to the 2.0.0 milestone Feb 17, 2020
@johnalarcon
Copy link
Collaborator

johnalarcon commented Feb 17, 2020

Endpoints can no longer be saved without an identifier; the buttons are disabled until that field is populated. Additionally, if a user hovers a disabled button, an alert is popped letting them know why it is disabled.

@johnalarcon johnalarcon added Status: Completed This item has been implemented or otherwise addressed. and removed Status: Pending This item is planned, but, has no projected timeline. labels Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed This item has been implemented or otherwise addressed. Type: Defect This item is an error or other behavior that negatively impacts code execution.
Projects
None yet
Development

No branches or pull requests

2 participants