Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin slug to image path and URL filters #54

Closed
johnalarcon opened this issue Sep 4, 2020 · 3 comments
Closed

Add plugin slug to image path and URL filters #54

johnalarcon opened this issue Sep 4, 2020 · 3 comments
Assignees
Labels
Status: Accepted This item has been accepted and will be implemented or otherwise addressed.

Comments

@johnalarcon
Copy link
Collaborator

johnalarcon commented Sep 4, 2020

Description

The image path/URL filters allow one plugin to override the header image of another; the alphabetically-last plugin using the filter takes precedence.

Steps to Reproduce

Documented in this issue, filed with Classic Commerce, and also discussed on the forum.

Expected Behavior

Plugins cannot override header images.

Additional Context

This is a bug, but, not considered critical at this time considering that the official ClassicPress Plugin Directory launch is imminent and the vast majority of 3rd party plugin updates will then be handled through the native update process. I'm creating this issue to ensure it is not lost in the mix and it will remain until an appropriate fix is implemented.

@johnalarcon johnalarcon added Status: Pending This item is planned, but, has no projected timeline. Type: Defect This item is an error or other behavior that negatively impacts code execution. labels Sep 4, 2020
@johnalarcon johnalarcon self-assigned this Sep 4, 2020
@nylen
Copy link
Contributor

nylen commented Sep 4, 2020

You probably already know this, but since this change requires plugin developers to make changes to their code, a semver major version bump is probably justified when these filters change.

@johnalarcon
Copy link
Collaborator Author

Yes, of course. 👍 Anytime the client file changed, it would be a major version bump.

@xxsimoxx
Copy link
Owner

xxsimoxx commented Jun 7, 2021

As in many other filters is up to the caller function to check if they are changing their own things.
Sure is misleading.
But if I add filters specific to the plugin but keep and deprecate misleading ones it requires just a minor version bump.
Am I right @nylen ?

@xxsimoxx xxsimoxx added Status: Accepted This item has been accepted and will be implemented or otherwise addressed. and removed Status: Pending This item is planned, but, has no projected timeline. Type: Defect This item is an error or other behavior that negatively impacts code execution. labels Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted This item has been accepted and will be implemented or otherwise addressed.
Projects
None yet
Development

No branches or pull requests

3 participants