You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The image path/URL filters allow one plugin to override the header image of another; the alphabetically-last plugin using the filter takes precedence.
Steps to Reproduce
Documented in this issue, filed with Classic Commerce, and also discussed on the forum.
Expected Behavior
Plugins cannot override header images.
Additional Context
This is a bug, but, not considered critical at this time considering that the official ClassicPress Plugin Directory launch is imminent and the vast majority of 3rd party plugin updates will then be handled through the native update process. I'm creating this issue to ensure it is not lost in the mix and it will remain until an appropriate fix is implemented.
The text was updated successfully, but these errors were encountered:
You probably already know this, but since this change requires plugin developers to make changes to their code, a semver major version bump is probably justified when these filters change.
As in many other filters is up to the caller function to check if they are changing their own things.
Sure is misleading.
But if I add filters specific to the plugin but keep and deprecate misleading ones it requires just a minor version bump.
Am I right @nylen ?
xxsimoxx
added
Status: Accepted
This item has been accepted and will be implemented or otherwise addressed.
and removed
Status: Pending
This item is planned, but, has no projected timeline.
Type: Defect
This item is an error or other behavior that negatively impacts code execution.
labels
Jun 8, 2021
Description
The image path/URL filters allow one plugin to override the header image of another; the alphabetically-last plugin using the filter takes precedence.
Steps to Reproduce
Documented in this issue, filed with Classic Commerce, and also discussed on the forum.
Expected Behavior
Plugins cannot override header images.
Additional Context
This is a bug, but, not considered critical at this time considering that the official ClassicPress Plugin Directory launch is imminent and the vast majority of 3rd party plugin updates will then be handled through the native update process. I'm creating this issue to ensure it is not lost in the mix and it will remain until an appropriate fix is implemented.
The text was updated successfully, but these errors were encountered: