Modal window missing version number

[johnalarcon]

Description

The modal popup window is missing the "Compatible up to:" version number. The update client file is requesting the current version via an option when the value is actually stored as a transient. This issue doesn't hinder operation of the Update Manager plugin or the update client file, however, it is important for UX. Because this issue lives in the update client file, it will have to be a major version release as that would be a breaking change.

The problematic code:

$this->cp_latest_version = get_option('cp_latest_version', '');

Solution

Store and retrieve version string from the correct context by replacing the above-noted code with the following. This solution is not yet tested and will need further study before implementation.

$this->cp_latest_version = get_transient('codepotent_update_manager_cp_version');
if (empty($this->cp_latest_version)) {
	$this->cp_latest_version = $this->get_latest_version_number();
}