Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-call status bar issue #1

Closed
ed-mejia opened this issue Aug 13, 2015 · 3 comments
Closed

In-call status bar issue #1

ed-mejia opened this issue Aug 13, 2015 · 3 comments

Comments

@ed-mejia
Copy link

Hi, great port to Swift :)

I'm having an issue when a phone call gets in and you are in the middle of a transition..

  1. Run the demo project on simulator
  2. Choose bottom modal style
  3. Toggle in-call status bar (command + Y )
  4. Toggle in-call status bar (command + Y ) - again
  5. Close the modal and watch the undesired effect

I'm still trying to find why this happen .

@xxxAIRINxxx
Copy link
Owner

Hi!,
I agreed.
I'm working in progress about that.

thanks.

@ed-mejia
Copy link
Author

Hey @xxxAIRINxxx , Good to see you updated the library..

It seems the in-call status bar issue is no more, I tested this last code base and it works properly, however it looks like now it does not support that your fromVC could have a navigation controller.

Just open the main Story board and embed a navigation controller to your view controller, run and test a transition.

Additionally It seems now we need to have a lot of boilerplate in the presenter when previously you just set your desired parameters and now you need to declare presentationBeforeHandler, dismissalBeforeHandler, dismissalCompletionHandler inside of every viewcontroller that will need to present another viewcontroller modally using the Animator.

Best regards!, and thanks for the great work you are doing here :)

@xxxAIRINxxx
Copy link
Owner

@ed-mejia
Hi!
Thank you for the advice!
fixed this issue.

Best regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants