Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 15 upgrade is now throwing warnings #25

Closed
cgood92 opened this issue Apr 24, 2017 · 3 comments
Closed

React 15 upgrade is now throwing warnings #25

cgood92 opened this issue Apr 24, 2017 · 3 comments

Comments

@cgood92
Copy link
Collaborator

cgood92 commented Apr 24, 2017

Once I upgraded my react project to React 15+ (currently 15.5.4), I am getting 3 warnings on every page of my storybook, and it's starting to get a little annoying. I have traced back 2 of the warnings to this npm package.

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

This is because React.PropTypes is now considered deprecated, in favor of using the npm library prop-types instead (see the top banner of https://facebook.github.io/react/docs/typechecking-with-proptypes.html). The conversion is fairly easy and painless. If I get the time, I'll make the PR myself. But, this issue would be nice to resolve soon.

This package is a dependency of @kadira/storybook-addon-actions@^1.0.2 and @kadira/storybook-ui@^3.10.1, which are being brought into my project.

Thanks

@cgood92
Copy link
Collaborator Author

cgood92 commented Apr 24, 2017

Here is the related PR: #26

@ndelangen
Copy link
Member

Storybook maintainer here, Can we help in any way?

@ndelangen
Copy link
Member

I'm now co-maintaining this package, and will be publishing a new version shortly fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants