Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we can use static width/height for the computed values as well #4004

Closed
moklick opened this issue Mar 12, 2024 · 2 comments
Closed
Assignees

Comments

@moklick
Copy link
Member

moklick commented Mar 12, 2024

We might be able to reduce the issues about dimensions with v12, if users don't have to apply dimensions changes if width and height are set.

@moklick moklick self-assigned this Mar 12, 2024
@moklick
Copy link
Member Author

moklick commented Mar 16, 2024

This is probably not a good idea because the behaviour would be inconsistent for flows that use node.width/node.height and those who don't. The questions remains if it's a good idea to handle dimension updates with onNodeChanges..

@moklick
Copy link
Member Author

moklick commented Apr 17, 2024

We decided to keep the dimension changes and store the information in node.measured.

@moklick moklick closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant