Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumericUpDown: Default foreground doesn't always match theme #46

Open
ionsharp opened this issue Mar 28, 2017 · 2 comments
Open

NumericUpDown: Default foreground doesn't always match theme #46

ionsharp opened this issue Mar 28, 2017 · 2 comments

Comments

@ionsharp
Copy link

If using the dark theme, the foreground is black when not in focus. It should be white like TextBox and then black when in focus. The only way to do this as is would be to explicitly define a style and set the foreground to the appropriate ThemeResource so it displays correctly for all themes.

@ionsharp
Copy link
Author

The best ThemeResource to use for this is SystemBaseHighColor because none of the predefined resources for TextBox have ideal values. The closest would be TextBoxBorderThemeBrush, which is #FFFFFFFF for dark and #A3000000 for light.

@xyzzer
Copy link
Owner

xyzzer commented Mar 28, 2017

Please send a pull request and I'll integrate it after a review and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants