Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support old package.json license format #54

Closed
shlomiassaf opened this issue Oct 19, 2018 · 2 comments
Closed

support old package.json license format #54

shlomiassaf opened this issue Oct 19, 2018 · 2 comments
Assignees
@xz64

Comments

@shlomiassaf
Copy link

It looks like v2 does not support packages with the old license formats...

This feature was added due to #5
https://github.com/xz64/license-webpack-plugin/blob/v1.5.0/src/LicenseExtractor.ts#L101

Are you planning to support this?

If not, please provide a meaningful error...

For example, I got this error:

TypeError: licenseType.indexOf is not a function
@xz64 xz64 self-assigned this Oct 19, 2018
@xz64
Copy link
Owner

xz64 commented Oct 19, 2018

This was fixed in v2.0.2 (see #53). I had forgotten to update the changelog, but it is updated now. Are you using version 2.0.2?

@xz64
Copy link
Owner

xz64 commented Oct 21, 2018

Will reopen if it is an issue in 2.0.2. Closing this for now.

@xz64 xz64 closed this as completed Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xz64 xz64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shlomiassaf @xz64