Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with thirdparty package (dragscroller) #77

Closed
tirolel opened this issue May 18, 2020 · 2 comments
Closed

Problem with thirdparty package (dragscroller) #77

tirolel opened this issue May 18, 2020 · 2 comments
Assignees

Comments

@tirolel
Copy link

tirolel commented May 18, 2020

Thank you for the great plugin.

I just noticed that I keep getting error when importing this package.
https://www.npmjs.com/package/dragscroll

it throws this error:
"ERROR in WebpackLicensePlugin: Could not find license info for dragscroll@0.0.8"

And here is my config option:

  new LicensePlugin({
      outputFilename: 'thirdPartyNotice.json',
      handleMissingLicenseText: (packageName, licenseType) => {
        console.log(`Cannot find license for ${packageName}`);
        return '';
      },
      handleMissingLicenseType: (packageName) => {
        console.log(packageName);
        return '';
      },
    }),

am I missing something or it is a bug?

@tirolel tirolel changed the title Problem with thridparty package Problem with thirdparty package (dragscroller) May 18, 2020
@xz64 xz64 self-assigned this May 18, 2020
@xz64
Copy link
Owner

xz64 commented May 18, 2020

dragscroll is missing a license field in its package.json . However the license for that package appears to be MIT, so you can just add an override to the plugin config like this to fix it:

new LicenseWebpackPlugin({
  licenseTypeOverrides: {
    dragscroll: 'MIT'
  }
})

@xz64 xz64 closed this as completed May 18, 2020
@tirolel
Copy link
Author

tirolel commented May 18, 2020

I see.
Thank you once again for the awesome work and fast reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants