Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error on empty pattern #8

Closed
yrtimiD opened this issue Dec 18, 2016 · 1 comment
Closed

Unexpected error on empty pattern #8

yrtimiD opened this issue Dec 18, 2016 · 1 comment
Assignees

Comments

@yrtimiD
Copy link

yrtimiD commented Dec 18, 2016

When patter isn't passed into constructor, plugin tries to report an error:
245 this.errors.push(plugin.errorMessages['no-pattern']);
but, at this point this.errors isn't assigned yet, and will be created only at
248 objectAssign(this, composedPlugin, instance(), opts);

as result, not very clear error is shown:

<redacted>\node_modules\license-webpack-plugin\index.js:245
    this.errors.push(plugin.errorMessages['no-pattern']);
               ^

TypeError: Cannot read property 'push' of undefined
    at new licensePlugin (<redacted>\node_modules\license-webpack-plugin\index.js:245:16)```
@xz64 xz64 self-assigned this Dec 18, 2016
@xz64 xz64 closed this as completed in 28f1e1d Dec 18, 2016
@xz64
Copy link
Owner

xz64 commented Dec 18, 2016

Thanks, fixed in 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants