Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncation of pupil/field coordinates in getTrace() and other related functions #81

Open
robbarnsley opened this issue Feb 28, 2018 · 0 comments

Comments

@robbarnsley
Copy link

Hi,

First off, thanks for the work you put into this.

I have an issue with:

https://github.com/indranilsinharoy/PyZDDE/blob/45dff7042b074574ef0ba5b6e8ee4155689f02bf/pyzdde/zdde.py#L3396

I am unsure why the float is truncated to 4 dp - it seems you're unnecessarily throwing away 32bit float precision. I have a ZPL macro utilitising a raytrace that is particularly sensitive to the pupil/field coordinates and the code above produces inconsistent results between ZPL/PyZDDE raytrace calls with the same input parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant