Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve filter_anonymizer configurations #22

Open
okkez opened this issue Dec 20, 2017 · 8 comments
Open

Improve filter_anonymizer configurations #22

okkez opened this issue Dec 20, 2017 · 8 comments

Comments

@okkez
Copy link
Collaborator

okkez commented Dec 20, 2017 •
edited
Loading

Current configuration is redundant and very complicated.
We can simplify parameters using record_accessor plugin helper.

My plan is followings:

  • organize configurations
    • remove mask/{key,key_chain,key_chanis}
    • use record_accessor plugin helper
    • add :deprecated option or :obsoleted options to obsolete configuration parameters
    • refactor code
    • update README.md

If you are OK, I will create patches for this issue.
@y-ken
Copy link
Owner

y-ken commented Dec 20, 2017

Sounds great. the record_accessor plugin helper is what I want to.
It is coming filter the nested keys. Please improbe with that plan.
Thank you.

@okkez
Copy link
Collaborator Author

okkez commented Feb 1, 2018

#25 is merged.

@okkez
Copy link
Collaborator Author

okkez commented Mar 12, 2018

I've finished works of this issue.
@y-ken Could you release new version such as v1.1.0?

@okkez
Copy link
Collaborator Author

okkez commented Apr 2, 2018

@y-ken Do you have any concern?

@y-ken
Copy link
Owner

y-ken commented Apr 2, 2018

hoops. I'll check it.

@okkez
Copy link
Collaborator Author

okkez commented May 24, 2018

@y-ken Any progress?

@okkez
Copy link
Collaborator Author

okkez commented Jul 24, 2018

@y-ken ping?

1 similar comment
@okkez
Copy link
Collaborator Author

okkez commented Sep 27, 2018

@y-ken ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okkez @y-ken