Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compression_scheduler doesn't report failure with partially invalid input paths #308

Open
haiqi96 opened this issue Feb 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@haiqi96
Copy link
Contributor

haiqi96 commented Feb 29, 2024

Bug

When handling compression job with multiple input paths, the compression scheduler silently log and skip any input that doesn't resolve to any real on disk path.

The compression is only marked as failure if none of the input paths resolve to valid path, otherwise CLP will skip compressing any invalid input path and report success.

We should update the reporting system so that we can report this kind of case as partially fail.

CLP version

469019e

Environment

Ubuntu 22.04

Reproduction steps

  • Build and start a CLP package
  • run ./sbin/compress.sh <valid_path> <invalid_path>
  • An error log can be observed in compression schdeuler log, but the compression returns success
@haiqi96 haiqi96 added the bug Something isn't working label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant