Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use broken with go mod #55

Closed
reedobrien opened this issue Jul 22, 2019 · 2 comments
Closed

use broken with go mod #55

reedobrien opened this issue Jul 22, 2019 · 2 comments

Comments

@reedobrien
Copy link

reedobrien commented Jul 22, 2019

When tryinq to use q in a project which uses go mod, any command run exits with an error. I am a little suspicious that the issue is really just a bad error message, but I don't quite see how it is getting triggered. Hopefully it make sense to you.

Here is a very simple example that shows the issue.

Create a dir with the following contents in main.go:

// Package main provides an example of q/mod failure
package main

import "github.com/y0ssar1an/q"

func main() {
	i := 1
	t := []int{1, 2, 3}
	q.Q(i, t)
}

run go mod init github.com/reedobrien/w

run go build and get the error:

go: finding github.com/golangci/tools v0.0.0-20180902102414-2cefd77fef9b
go: github.com/golangci/tools@v0.0.0-20180902102414-2cefd77fef9b: unknown revision 2cefd77fef9b

I don't see golangci or tools in the q repo... so I suspect someone doing something clever vending dependencies, a bug in go mod, or both. Also I've been away from go for a bit and haven't used modules in anger before my current project. So I am a bit lost with them. Hopefully this rings a bell in your head.

@ryboe
Copy link
Owner

ryboe commented Jul 29, 2019

Sorry for the trouble, @reedobrien. The dependency on golangci-lint was removed on master branch, but it was still present in the latest tagged release (v1.0.6). I just cut v1.0.7, which should resolve the issue after you run this command:

GO111MODULE=on go get github.com/y0ssar1an/q@v1.0.7

Thanks for taking the time to report the issue! Please reopen if the issue persists.

@ryboe ryboe closed this as completed Jul 29, 2019
@reedobrien
Copy link
Author

WFM now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants