New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom styles #69
Conversation
@yaahc: So there is a merge conflict. These PRs, basically, are the first time I used Git for something more complex than "pull/commit/push", so I never had a merge conflict. Do I need to do anything, or will you fix this? |
As with the other PR, the test suite will fail because I didn't include the test data. I will generate and include them now. Regarding the merge conflict: I looked at the conflict and it looks very simple. But I don't want to resolve it myself (in case I'm missing something and will break something). |
I can fix the merge conflict, no worries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much for putting in the time to set this all up. I'm not 100% done with the review but I figured I'd post the comments I have so far. I'm going to try to fix the merge conflict now and then I'll go ahead and check into the comments around STYLES.get()
and then finally if I have time before the error handling project group meeting in 20 minutes I'll take a look at the color-spantrace PR.
Okay I went ahead and fixed the merge conflict but It looks like the |
Thanks, for the feedback, @yaahc! In the coming few days I should have enough time to work through your suggestions here and at |
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
Alright, I believe I have implemented all suggestions. Let me know if I missed anything! I realized I mixed up Please keep an eye open for mistakes like these at the public API level... 😅 As with I have a few additional questions:
Should we ask for this? Personally, I don't care much, but maybe there will be new merge conflicts in the future, otherwise. If not, and you'd like to properly test my PRs, you could patch your version of
Personally, I think this could confuse people who look at |
I'm sorry for not replying to this for so long, life has been getting in the way. Just know that this is high on my list of priorities and I'll get to this as soon as I can. |
Don't worry, I was assuming exactly this, and I have enough other stuff to do :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, pending review of how the docs look and writing a changelog.
examples/theme.rs
Outdated
// Using `Option` to add dependency code. See https://github.com/yaahc/color-eyre/blob/4ddaeb2126ed8b14e4e6aa03d7eef49eb8561cf0/src/config.rs#L56 | ||
None::<Option<()>>.ok_or_else(|| create_report(msg)).unwrap_err() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is sick
3026f19
to
b5ee9ba
Compare
0b56411
to
227eb5c
Compare
ty again for all of this amazing work @d4h0. release And just once again, I'm really sorry about how long I took on this. I know you understand but still, ty for handling the delay so graciously. |
Awesome – thank you so much, @yaahc! 😁 I've added two comments, but I guess you got notifications for them. I hope it wasn't too difficult to finish this. If there is anything I could do better when contributing to a project, please let me know! (I guess, at the very least, I need to learn Git properly... 😅) |
You did fantastic work, and no it wasn't difficult. The test took some thinking to figure out how to get it to work on all our CI configurations but it ended up being simple and working great with all the helper code you setup. |
Awesome, thanks! 😄
I think I had similar problems while creating the test (e.g. because of my workspace configuration). Hopefully, this kind of problem will not happen too often... 😅 |
Hi,
This implements support for custom styles (required for #58).
There are a few comments with questions for you, which I have marked with "XXX" (so they are easy to find with grep or ripgrep).
Please let me know if there is any problem or if something could improve. If you want to rename something (English is not my native language), just tell me to do so! :)
The test data are not included at the moment, in case you want to tweak the styles a bit (you probably want, see my "XXX" comments).
After you are ready, you just run the tests in "tests/styles.rs" and follow the instructions to generate the test control data.