Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a version alert to settings panel #11

Merged
merged 8 commits into from Nov 21, 2022
Merged

Add a version alert to settings panel #11

merged 8 commits into from Nov 21, 2022

Conversation

Chevindu
Copy link
Member

@Chevindu Chevindu commented Nov 7, 2022

  • Added a basic network class to manage REST calls.
  • Added a REST call in AppManagementService constructor to get the latest release version.
    • This is an unauthenticated API and the rate limit is 60 requests per hour. Assumption here is that a user will not close and re-open FIXYL 60 times within an hour.
  • Added an info alert in the bottom area of Settings drawer to indicate if there is a newer version available.

version-available

@Chevindu
Copy link
Member Author

  • Added a version validity period of 1 day to avoid GitHub's rate limiting
  • Changed the alert to an info Toast, so the user can see it without going to Settings

2022-11-20_10-56

DhananjayaR
DhananjayaR approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@DhananjayaR DhananjayaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

@DhananjayaR DhananjayaR merged commit 00d469e into yaalalabs:master Nov 21, 2022
@Chevindu Chevindu deleted the feature/version-alert branch September 17, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhananjayaR DhananjayaR DhananjayaR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chevindu @DhananjayaR