Issue with older versions of Jinja2 version 2.2 in Ubuntu12.04 image.

[yabhinav]

This issue is similar to ansible/ansible#20309

- name: Restart NTP
  service: name={{ntp_service_name}} state=restarted enabled=yes
  become: True
  when: ntp_conf.changed or ntpd_conf.changed

TASK [role_under_test : Restart NTP] *******************************************
fatal: [localhost]: FAILED! => {"failed": true, "msg": "The conditional check 'ntp_conf.changed or ntpd_conf.changed' failed. The error was: 'AnsibleEnvironment' object has no attribute '_generate'\n\nThe error appears to have been in '/etc/ansible/roles/role_under_test/tasks/main.yml': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Restart NTP\n  ^ here\n"}

Should be fixed with next release as the patch has been released. Or we can test different version of Jinja2 in the image

[yabhinav]

the issue is fixed by moving the above task to handlers

Also user quotes for older versions of Jinja2. Examples

when : "{{ firewall_service is defined }}"

when: "{{ ansible_os_family == 'Redhat' and ansible_selinux is defined and 'status' in ansible_selinux and ansible_selinux.status == 'enabled' }}"

when: "{{ ansible_os_family == 'Debian' }}"

Surrounding in quotes seem to have solved the problem, might be due to the older versions not supporting free forms like

when :  firewall_service is defined 

when: ansible_os_family == 'Redhat' and ansible_selinux is defined and 'status' in ansible_selinux and ansible_selinux.status == 'enabled' 

when:  ansible_os_family == 'Debian'