Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another broken WYSIWYG editor #20

Closed
cheery opened this issue Sep 20, 2013 · 8 comments
Closed

Yet another broken WYSIWYG editor #20

cheery opened this issue Sep 20, 2013 · 8 comments

Comments

@cheery
Copy link

cheery commented Sep 20, 2013

The problem with contenteditable is that it does whatever it likes to do.

I played with the editor and quote features a while, and managed to get multiple paragraphs inside each other like this:

<p><q>idm</q><p><q>idm</q><p><q>idmidmidmmid</q><p><q>dimidmimd</q><p><q>t comes with it: the most popular gun in American crime. Like they're actually proud of that shit.  </q><p><p>idmidm</p></p></p></p></p></p></p>

But it looked as if it all was correct. though.

I think your editor is as fucked as the rest of them in this category.

@daviferreira
Copy link
Member

🍻

@ErtugKaya
Copy link

Disappointment and bad day huh? I don't think that's a proper way to motivate developer. Maybe, after you get over your disappointment, you may like to apologize. An editor does not worth to hurt feelings.

@cheery
Copy link
Author

cheery commented Sep 20, 2013

Don't get me wrong, I still like the concept. I also like beer.

Also what makes you think I do this to motivate developers? I don't care whether they are motivated or demotivated. If they want to spoil the WYSIWYG category with another broken editor, what could I do?

Every single WYSIWYG editor that appears at google has this same problem, and it's fatal because these editors are supposed to be given to normal people, who do not care about markup quality. They get messed up layout and wonder what's wrong. I'm pissed off at grand scale of this thing, not just disappointed. I hate writing some stupid markup language such as markdown or mediawiki syntax just because these things do not work for everyone.

@illourr
Copy link

illourr commented Sep 20, 2013

@cheery Do you want to help fix it or just bitch about it?

@jakiestfu
Copy link

@cheery I would agree to some point, but as @illourr says, being mean about it doesn't help. I am also (annoyed) slightly at the fact that there are now so many repos similar to this. There is ZenPen, Grande.js, and my own repo, Medium.js which attempts to solve the contenteditable problems, not the editor toolbar.

@cheery Why did you create this repo? Why didn't you feel it necessary to contribute instead of increasing the amount of fragmentation within this area. I'm all for open source work so thank you for this, but it would make more sense to contribute at this point unless your repo redefines what it means to be a Medium Editor

@Warry
Copy link
Contributor

Warry commented Sep 21, 2013

I believe that my pull request fixed your very problem.

@daviferreira
Copy link
Member

Cheers 👍

@cheery
Copy link
Author

cheery commented Sep 22, 2013

I cloned the repository and threw it into a server to try it out. It still doesn't work.

It doesn't stack paragraphs inside each other anymore. Instead it splits the rest of the document into div tag now, when you're splitting a quote. Like this:

<q>x</q>
<div><q>y</q>
    <p>rest of the document</p>
</div>

I also managed to produce text without a container, by removing all the contents in the editable. Before that I managed to get an empty trailing div.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants