Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release patch release v0.20.3 with API breaking changes reverted #122

Open
1 of 4 tasks
matthewfeickert opened this issue Feb 18, 2022 · 1 comment
Open
1 of 4 tasks
Assignees

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 18, 2022

As outlined in #116 (comment), to deal with the fact that PR #92 introduced an API breaking change into patch release v0.20.2 we should

@matthewfeickert
Copy link
Member Author

Ensure the test suite is passing on branch v0.20.x

Hm, even after revering PR #92 the test suite is currently failing in quite a few places. This is strange as PR #92 passed its test suite (was on Travis CI here). The test suite is passing on master though, so this is confusing.

I'm attaching the diff that I get from

git diff origin/master

and from

git diff ff4239e b03a637

which should be inverses of each other basically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants