Updating from GitHub adds an undesired suffix to the plugin folder name.

[brasofilo]

If we use a GitHub zip file as download_url, e.g., https://github.com/user/git-name/archive/master.zip, the updated plugin receives an extra folder suffix: /wp-content/plugins/plugin-slug-master/.

I made a hack to deal with this, but wonder if there'd be a better alternative...

add_filter('upgrader_source_selection', 'ultra_hack', 1, 3);
function ultra_hack( $source, $remote_source, $thiz )
{
    if( not_my_plugin() )
        return $source;

    $path_parts = pathinfo($source);
    $newsource = trailingslashit($path_parts['dirname']). trailingslashit('plugin-slug');
    rename($source, $newsource);
    return $newsource;
}

[jaredatch]

Another plugin that is similar to this, yet tailored for GH is https://github.com/jkudish/WordPress-GitHub-Plugin-Updater

[brasofilo]

Thanks, @jaredatch 👍

[YahnisElsts]

@brasofilo I don't think there is a non-hacky way to accomplish that. The plugin suggested by @jaredatch uses a similar hack to rename the destination directory, except it relies on the "upgrader_post_install" filter instead of "upgrader_source_selection".

[brasofilo]

@YahnisElsts , yep, discovered that two days ago... Thanks for the feedback!