Add logic to rename aggregation to avoid name collision

[bharatmotwani]

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

[michael-mclawhorn]

Let's make sure to add a test where we hit the double rename problem. You can probably feed the same metric multiple times through the transformer manually.

[michael-mclawhorn]

Ok.

I apologize for asking for a bigger change on a followup review.
Per the discussion I just shared, I'd prefer to move the responsibility for the generated-metric-info collision resolution up to ProtocolMetricImpl.apply rather than having it in the MetricMaker code.

My proposal is to lift up 'renameIfConflicting' and the rename to ProcolMetricImpl, rename based not on every agg and post agg but instead on the metric name, and use the protocol name as the prefix for the renaming.

[michael-mclawhorn]

add default implementation to base protocol maker
change changelog to reflect
unit test the rename behavior

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

84.6% Coverage
0.0% Duplication

The version of Java (1.8.0_141) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here