We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While running a debugging session, I accidentally noticed this line of code:
https://github.com/yahoo/fili/blob/master/fili-core/src/main/java/com/yahoo/bard/webservice/web/DimensionApiRequestMapper.java#L62
By interface contract, apply should throw RequestValidationException instead of BadApiRequestException
apply
RequestValidationException
BadApiRequestException
Another consequence is a bug where dimension servlet won't be able to catch error from requestMapper.apply(apiRequest, containerRequestContext):
requestMapper.apply(apiRequest, containerRequestContext)
https://github.com/yahoo/fili/blob/master/fili-core/src/main/java/com/yahoo/bard/webservice/web/endpoints/DimensionsServlet.java#L156
The text was updated successfully, but these errors were encountered:
QubitPi
No branches or pull requests
While running a debugging session, I accidentally noticed this line of code:
https://github.com/yahoo/fili/blob/master/fili-core/src/main/java/com/yahoo/bard/webservice/web/DimensionApiRequestMapper.java#L62
By interface contract,
apply
should throwRequestValidationException
instead ofBadApiRequestException
Another consequence is a bug where dimension servlet won't be able to catch error from
requestMapper.apply(apiRequest, containerRequestContext)
:https://github.com/yahoo/fili/blob/master/fili-core/src/main/java/com/yahoo/bard/webservice/web/endpoints/DimensionsServlet.java#L156
The text was updated successfully, but these errors were encountered: