Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty post-aggs serialization #762

Open
QubitPi opened this issue Aug 16, 2018 · 1 comment
Open

Empty post-aggs serialization #762

QubitPi opened this issue Aug 16, 2018 · 1 comment
Assignees

Comments

@QubitPi
Copy link
Contributor

QubitPi commented Aug 16, 2018

If a query does not have post aggregation spec, it still includes it as an empty spec. This wastes network resources and reduces the readability of Druid query.

{
    "queryType" : "...",
    "dataSource" : ...,
    "granularity" : ...
    "intervals" : ...,
    "dimensions" : [ ... ],
    "aggregations" : [ ... ],
    "postAggregations" : [ ]
  }
@michael-mclawhorn
Copy link
Contributor

I was recently reminded that making this change effective immediately will break tests. We need to feature flag this or in some other way make this not effective immediately and provide migration notes.

This actually highlights that making some partial-query matching tests (as opposed to our full query matching tests) would be a big help for both fili testing and downstream testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants