Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSourceConstraint class hierarchy is too rigid #996

Closed
efronbs opened this issue Dec 20, 2019 · 0 comments
Closed

DataSourceConstraint class hierarchy is too rigid #996

efronbs opened this issue Dec 20, 2019 · 0 comments

Comments

@efronbs
Copy link
Contributor

efronbs commented Dec 20, 2019

Some downstream customers have had issues extending and using DataSourceConstraint and its subclasses. It should be made more extendable and flexible.

An interface has been extracted from the DataSourceConstraint class. The original DataSourceConstraint implementation has been renamed to BaseDataSourceConstraint. The rest of the class hierarchy has been maintained.

To absorb these changes switch all instances of explicitly creating a DataSourceConstraint to creating a BaseDataSourceConstraint. No other changes should be required.

A new method has been added to the interface which allows filtering a DataSourceConstraint's Dimenisions using a predicate. This is the Dimension side of the functionality already provided by withMetricIntersection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants