allow onClick handler to be overwritten for customization

YahooArchive · Nov 5, 2014 · a9a09c0 · a9a09c0
1 parent 9dd634b
commit a9a09c0
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/lib/NavLink.js b/lib/NavLink.js
@@ -36,14 +36,14 @@ NavLink = React.createClass({
         if (!this.props.href && routeName && context && context.makePath) {
             this.props.href = context.makePath(routeName, this.props.navParams);
         }
+        console.log('....... this.props=', this.props);
         return React.createElement(
                 'a',
-                objectAssign({}, this.props, {
-                    onClick: this.dispatchNavAction,
-                    href: this.props.href
-                }),
+                objectAssign({}, {
+                    onClick: this.dispatchNavAction
+                }, this.props),
                 this.props.children
-            );        
+            );
     }
 });
 

diff --git a/tests/unit/lib/NavLink-test.js b/tests/unit/lib/NavLink-test.js
@@ -9,9 +9,14 @@ var React,
     jsdom = require('jsdom'),
     expect = require('chai').expect,
     contextMock,
+    onClickMock,
     routerMock,
     testResult;
 
+onClickMock = function () {
+    testResult.onClickMockInvoked = true;
+};
+
 routerMock = {
     makePath: function (name, params) {
         var paths = ['/' + name];
@@ -97,4 +102,16 @@ describe('NavLink', function () {
             }, 10);
         });
     });
+
+    it('allow overriding onClick', function (done) {
+        var navParams = {a: 1, b: true},
+            link = ReactTestUtils.renderIntoDocument(NavLink( {href:"/foo", context:contextMock, navParams:navParams, onClick: onClickMock}, React.DOM.span(null, "bar")));
+        expect(testResult.onClickMockInvoked).to.equal(undefined);
+        ReactTestUtils.Simulate.click(link.getDOMNode());
+        window.setTimeout(function () {
+            expect(testResult.dispatch).to.equal(undefined);
+            expect(testResult.onClickMockInvoked).to.equal(true);
+            done();
+        }, 10);
+    });
 });